fix: correct calculations for unordered price items with discounts#257
Merged
fix: correct calculations for unordered price items with discounts#257
Conversation
… total calculation logic
alexmarqs
changed the title
JoFont
approved these changes
Nov 26, 2025
Contributor
JoFont
left a comment
JoFont
left a comment
There was a problem hiding this comment.
Awesome! Yeah, tricky one this one. I don't know how this was not caught earlier...
paulofph
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue:
When we have more than 2 onetime items where the second has a discount, the before_discount_amount_total for the recurrence is incorrectly calculated because it didn't account for the first item's amount (which had no discount).
The Fix:
Changed the logic to initialise existingRecurrenceBeforeDiscountAmountTotal with the recurrence current amount_total (minus the item being added) when it's undefined, ensuring all previously added items are included in the before-discount calculation, even if they didn't have discounts themselves.